Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change terminology up upstream-diff-to-release #5085

Merged
merged 2 commits into from
Aug 17, 2021
Merged

change terminology up upstream-diff-to-release #5085

merged 2 commits into from
Aug 17, 2021

Conversation

ScottSuarez
Copy link
Contributor

upstream diff makes less sense in light of the functionality. Changing this in accordance with
hashicorp/terraform-provider-google#9798

Release Note Template for Downstream PRs (will be copied)

@google-cla google-cla bot added the cla: yes label Aug 13, 2021
@ScottSuarez
Copy link
Contributor Author

will checkin hashicorp/terraform-provider-google#9798 afterwards

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 12 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 2 files changed, 13 insertions(+), 13 deletions(-))

rileykarson
rileykarson reviewed Aug 13, 2021
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See hashicorp/terraform-provider-google#9798 (comment) - I don't think downstream is a significant change from upstream, and released/published is probably more clear.

@ScottSuarez ScottSuarez changed the title change terminology up upstream-diff-to-downstream change terminology up upstream-diff-to-release Aug 13, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 12 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@ScottSuarez
Copy link
Contributor Author

ping

@ScottSuarez ScottSuarez merged commit a6826c0 into GoogleCloudPlatform:master Aug 17, 2021
@ScottSuarez ScottSuarez deleted the change-upstream-to-downstream branch August 17, 2021 22:02
This was referenced Aug 17, 2021
Merged
Merged
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
@ScottSuarez @khajduczenia
change terminology up upstream-diff-to-release (GoogleCloudPlatform#5085
0a1c0a0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottSuarez @modular-magician @rileykarson